Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

Hi @nfmohit, this IB is technically fine and I am happy to :white_check_mark: it as it is. However, I would say that it's a bit on the verbose side and...

Update: I've realised that this issue should be covering the case where an existing property _does_ exist too. The implementation should not need to change for this, but I will...

Hey @aaemnnosttv, I have merged `develop` to resolve conflicts and fixed subsequently broken tests. While fixing up for the `AdminBarWidget` component I also spotted an out-of-date story which I have...

Hey @nfmohit, this IB looks good. One minor tweak I would suggest is to use the filename `test-utils.js` rather than `utils.js`, just to make it clear that what's in the...

Thanks @nfmohit! IB :white_check_mark:

Thanks @nfmohit, not sure how I missed that. I've updated the rest of the issue accordingly. Cheers!

@makiost I tweaked the QAB to explicitly mention the entity dashboard rather than just the dashboard.