Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

Thanks @jimmymadon! IB :white_check_mark:

@nfmohit this IB looks good, the component path will likely need updating - see https://github.com/google/site-kit-wp/issues/5270#issuecomment-1196522807 - that aside this looks good to go! The updated path will probably be: `assets/js/modules/analytics-4/components/dashboard/ActivationBanner/Success.js`

Thanks @nfmohit! IB :white_check_mark:

Hi @mohitwp, the 2nd scenario refers to the case where the Property ID selected in the Property dropdown matches the Property ID found in the GTM container. I have tweaked...

Thanks for calling this out @FlicHollis, I've removed my assignment :+1:

@aaemnnosttv I have added this issue along with the AC, please could you take a look?

Hi @felixarntz, thanks for raising this. To be clear, the `RecoverableModules` and `WidgetRecoverableModules` components were added via a previous [issue](https://github.com/google/site-kit-wp/issues/5376) and we don't want to remove those. However there is...

Hey @tofumatt - turns out, we do refer to it as "GA4" in a number of user-facing spots. I have found references in: https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/analytics/components/common/GA4Notice.js https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/analytics-4/components/settings/SettingsUseSnippetSwitch.js https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/analytics-4/components/setup/SetupUseSnippetSwitch.js https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/analytics-4/datastore/webdatastreams.js (possibly - not...

Hey @jimmymadon, you have raised an interesting point in the IB about code reuse. On reflection, I actually think this is a case where we should go a bit further....