Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

Having looked into it I have realised this was due to a mistake on my part in the IB for https://github.com/google/site-kit-wp/issues/5275 - which is closed and so it seems appropriate...

Hey @wpdarren, apologies for not spotting this earlier - I guess I applied the fix in a bit of a hurry. I've realised it looks a bit glitchy when showing...

> @techanvil I've just set up a test and yes, I can see what you mean. I think the progress bar is a good solution so that there's no confusion...

Hi @wpdarren, thanks for spotting this. The problem here is that the "Congrats on completing the setup for Site Kit!" success notification is presently hard wired to show up when...

@FlicHollis this one is still blocked, pending the execution of 5047. I was still planning on working on the IB, as I did the IB for 5047 and the process...

@eugene-manuilov, thanks for raising this - it's a really good point. I had forgotten that the _edit_ versions of the expanded sections for modules which are not yet setup are...

> @nfmohit, when double-checking the [Figma design and the comments](https://www.figma.com/file/vMaCWwr6lpk4PrJWb7jIpz/GA4-Banner-Input?node-id=1285%3A2032) related to it, it seems we should not open the accordion. The gray CTA button indicates it's disabled. However, there...

Hi @eugene-manuilov, thanks for pointing that out - definitely a good shout to expand on this. My take on this, is the key objective is to avoid inconsistent usage of...

Hi @jimmymadon , a small but important detail - looking at the components mentioned in the IB, the `hasModuleAccess` prop is being explicitly checked for `=== false`, rather than just...