Tom Rees-Herdman
Tom Rees-Herdman
Note that since my previous comment we've decided to split this issue into two, with https://github.com/google/site-kit-wp/issues/8652 being created for the initial KM Selection Panel refactor.
> @techanvil Just wanted to check if this issue deals with adding the fetched User Audiences or the newly created Site Kit audiences to the list of `configuredAudiences`. If so,...
Hi @jimmymadon, this AC is almost there, however, and with apologies for the moving target, the design doc has or may change a bit in a couple of relevant areas,...
Thanks for the spot(s) @zutigrm! I've accepted your suggested changes in the design doc, and tweaked it a little further.
@jimmymadon I'm moving this to the Backlog to help clarify which issues still need to be finalised in the design doc.
@jimmymadon, just a heads up that I have made this issue dependent on https://github.com/google/site-kit-wp/issues/8238 as we can reuse the component introduced there for the success banner (I also added a...
The design doc has progressed to a point where this is now unblocked, so I've moved it out of the Backlog and will continue working on the AC myself.
Hi @kuasha420, thanks for drafting this IB. A few points: - It's worth a mention of the user count ordering when initially populating `audiencesToConfigure`. - Also, we should only be...
Thanks @kuasha420! Thanks for clarifying re. the in progress state. The copy `Enabling groups` is correct, we can keep that as it is. I think this just needs the Test...
IB LGTM, thanks @kuasha420! :white_check_mark: