Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

Thanks @benbowler. Good shout, #8484 looks like an appropriate issue to tackle this in. Please do go ahead as you have suggested. Cheers!

Thanks @benbowler. As mentioned on [Slack](https://10up.slack.com/archives/CBKKQEBR9/p1713281583711679?thread_ts=1713277869.383479&cid=CBKKQEBR9) this should go back to @zutigrm to finish his review, so I've assigned it back to him. Although, if he's off tomorrow I'd be...

Hi @kelvinballoo, thanks for raising these points. I'm going to answer these as I've got more context on the issue and epic as a whole. I'll then let @kuasha420 create...

That's great, thanks @kuasha420. Back to you for another pass, @kelvinballoo!

Thanks @kelvinballoo. The ellipses will be covered in the followup issue https://github.com/google/site-kit-wp/issues/8626.

Hey @zutigrm, as mentioned on [Slack](https://10up.slack.com/archives/CBKKQEBR9/p1707132930927679) I've added a [code organization](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.mlj74m7pz9gr) section to the design doc to help keep us aligned. The upshot is that we should create this new...

Thanks @aaemnnosttv @nfmohit - it doesn't need to be behind the `adsModule` feature flag, we can indeed start using this straight away for Analytics. Back to you Evan for a...

Oh yes, I should have done that too. Thanks @aaemnnosttv!

Hi @nfmohit, thanks for raising this. The intention of the AC point _is_ that we should be caching the list of destination IDs, and as you've suggested it seems a...