Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

Thanks @nfmohit! I've spotted something else, sorry for not realising yesterday. Bear in mind this AC point: > The User_Input_State class should be removed and its usage should be refactored...

Thanks, @nfmohit. LGTM! IB :white_check_mark:

IB :white_check_mark: Although, I think the estimate of 3 could be a little optimistic, so am bumping to a 7.

Hey @nfmohit, taking looking at this in lieu of @tofumatt - seems to me your proposed PR solves the problem well enough without needing to make the branch name unique....

I am also seeing failures on my Linux workstation(Ubuntu 22.04, AMD64), similar to the description but more, ~30 failures here.

Hi @felixarntz, looking into this, and having discussed with @makiost, we think the issue may need to be reconsidered. It doesn't look like any of the existing [`ErrorNotice`](https://github.com/google/site-kit-wp/blob/22ac3021f2028feb0be0f855c3a1a1346d6e2113/assets/js/components/ErrorNotice.js) components will...

Hi @felixarntz, that sounds good to me, one thing to note is that `args` is MD5 encoded in the error key, so we can't extract the args from the key,...