Yat Ho

Results 355 comments of Yat Ho

There are still quite a lot of work to be done before this PR can run fast, but right now testers can verify whether the code logic is correct (no...

This PR deals with peer info objects, not the peers themselves. We use them to store information about a peer that is useful even when we are not currently connected...

@ckerr Ready for review. The to-do items in https://github.com/transmission/transmission/pull/6614#issuecomment-1949627038 will be for future PRs.

@ckerr Please help bump `small`. The fix was simpler than I expected, so I got it done right away. > * Replace `std::unordered_map` with a flat map implementation. Unfortunately the...

> Please help bump `small`. The fix was simpler than I expected, so I got it done right away. Sorry, another fix is needed before that: https://github.com/alandefreitas/small/pull/44

I'm just going to take the performance hit in exchange for stable and reasonably maintainable code. Plus, if #6712 is also merged, then I don't think the performance hit will...

DhtTest failure not related to this PR.

@Coeur @nevack Could one of you please help look if Xcode builds can also include header files from `miniupnpc` instead of `miniupnp`? If it is not straightforward, then I'll just...

@nevack Thanks! I removed the part that renames `VERSION` to `miniupnp_VERSION`, still seems to work.