Yat Ho
Yat Ho
> So I guess this just means changing on_error() to rely on `AwaitingYb` and not `(AwaitingYb or AwaitingVc)` ? I think so.
I couldn't reproduce on d42d0f3f3f50c01cda1d9f7180d1f4a3ef8aba63 either...
Closing for now due to lack of response.
I think the culprit is here: https://github.com/transmission/transmission/blob/ec5296c8dc15c0d51014d67ef93658e5569f354c/libtransmission/torrent.cc#L1825-L1832 I don't know why `recent_change` is needed.
~Oh, it was to prevent overriding the `date_done_` value set in these locations:~ https://github.com/transmission/transmission/blob/ec5296c8dc15c0d51014d67ef93658e5569f354c/libtransmission/torrent.cc#L907-L908 https://github.com/transmission/transmission/blob/ec5296c8dc15c0d51014d67ef93658e5569f354c/libtransmission/torrent.cc#L2270-L2271 Edit: It's not.
But then I don't get it, why was this wrapped in an `if` as well? https://github.com/transmission/transmission/blob/ec5296c8dc15c0d51014d67ef93658e5569f354c/libtransmission/torrent.cc#L1812-L1820
Not that wrapping the log statement in the `if` causes a major issue, I was trying to figure out what `recent_change` was intended for. Usually these seemingly redundant code are...
I looked into it again, I think I get it now. `recent_change` first came from https://trac.transmissionbt.com/changeset/2423, which was then squashed into 1 commit in `main` (then `trunk`), shown here (line...
> Whoops, forgot to co-author you, your changes are good, is there something I can revise to co-author you? Don't worry about it.
@Rukario I think you swapped the old and new screenshot.