Tymon Tobolski
Tymon Tobolski
@thiagopromano This looks good! Could you add a simple test case & add the new option to Hackney adapter moduledoc?
I would discourage usage of macros for DRY. It's better to use the [Runtime middleware](https://github.com/teamon/tesla#runtime-middleware). I think `Tesla.Middleware.Opts` should use `Keyword.merge`, instead of simple `++`, but unfortunately it would be...
Hey @sambhavsaxena, are you still up for this one?
Unfortunately streaming response body is not implemented, but it could be done. I can imagine something like: ```ex case Tesla.get(client, "/stream", stream_response: true) do {:ok, env} -> # on successful...
I'd go with `Tesla.get(client, "/path", response: :stream)` (instead of `stream_response: true`)
> DISCLAIMER: I'm obviously biased here The way I've always imagined client libraries build around tesla is that they expose a way to pass a custom `%Tesla.Client{}` to add/change functionality...
You *can* override adapter in runtime, but it's not pretty and it needs to be improved a lot. ``` iex(1)> Tesla.get("https://httpbin.org/ip") {:ok, %Tesla.Env{status: 200, ...}} iex(2)> client = Tesla.build_adapter(fn env...
Yes, yes, and yes, all you say is (unfortunately) true. Thanks for starting the discussion around it! I hope we can get it solved in the near future.
Take a look at https://github.com/plataformatec/faraday-http-cache/
Actually I did :) On Her side this is as simple as adding `c.user :http_cache` to faraday connection middleware. In fact Her does not care (nor it should) about cache...