Tymon Tobolski

Results 130 comments of Tymon Tobolski

@jandudulski any plans for this?

Thanks, but isn't the https://github.com/monterail/angular-faye#configure-faye-client enough? Besides that, `$faye` takes now three parameters: `url`, `fun`, `opts` so `$faye("url", {...})` syntax will not work.

I mean: ``` coffee $faye = (url, fun, opts = {}) -> ... $faye("some url", { my: opt }) # inside: url == "some url" fun == { my: opt...

But if you pass options as second parameter then variable `fun` will hold those options and `options` variable will be empty hash so options will not be applied and fun...

This looks fine. Could you rebase into master and add a note to the README?

First I thought about Faraday middleware, but we need to save this new token into session, and this can be done only on controller level. I wonder if we're not...

... and storing access/refresh tokens in User model (in client app) also seems a bit hackish :/

Why do we need to do this? Shouldn't RailsSSO be able to use any omniauth-xyz?

Why hacked oauth? (But yes it makes sense to stick to oauth for rails sso) On Thu 27 Aug 2015 at 11:11 Jan Dudulski [email protected] wrote: > Not any. Only...