Thomas Reynolds

Results 94 comments of Thomas Reynolds

I'm not certain 5.x will ever be released. the brave are welcome to use the master branch, and fixes are going in to it for modern support, but I also...

5.x is probably abandoned. Commented on not breaking config api compat. Might be best to re-target at 4.x/main

I would recommend having two renderers. They get enabled if the gem they depend on is present (there's other examples of this in the code where adding a templating engine...

@markets looks like a static helper function. probably best to see if there's access to the blog instance/config from wherever its being called. Can add params/options to that helper to...

Published as v4.4.3 https://rubygems.org/gems/middleman/versions/4.4.3

Can we do this without dropping support for Haml 5? I'd prefer not to have a breaking change.

Any update on this @DrewRidley?

I'm interest in this part. A home for the DO classes and getting them compiled correctly. Seemingly need to be concatenated? > It looks like the best way to support...

Can you share the full project source? Can you also post expected output

I think it's because the code is using the global "index file" to figure out the paths. https://github.com/middleman/middleman/blob/e1bc04e9a3f17c71c927e5a2baf8aab5a7e2de7f/middleman-core/lib/middleman-core/sitemap/extensions/traversal.rb#L25 This is set here: https://github.com/middleman/middleman/blob/e1bc04e9a3f17c71c927e5a2baf8aab5a7e2de7f/middleman-core/lib/middleman-core/application.rb#L117-L118 But it's used for a bunch of...