Thomas Dietert

Results 8 comments of Thomas Dietert

@dgaw I have found an ad-hoc fix for this situation. If you fix the type of `require` to be monomorphic in it's return type: ```haskell require :: Configurable a =>...

@morganteg amazing, thank you!

@dcoutts could you open source such an implementation and name it `exceptions-Y` or something of the sort? I totally agree with the proposed changes, and would love to see the...

Hi @HeydrichBeillschmidt, when I merge your changes into my fork and try to call `run_auto_sharding_pass` on a simple MNIST model, I get this error: ``` File "/workspaces/alpa/alpa/shard_parallel/auto_sharding.py", line 355, in...

@HeydrichBeillschmidt I've solved this problem by undoing the part of the diff where you build an instruction sequence from the `entry_computation->instructions()` list. You passed this `entry_sequence` value to `BuildStrategyAndCost`, instead...

@HeydrichBeillschmidt Thanks for your response! We have tried your latest changes and they work well for us, thank you. We have not validated the output, that the while loops are...

Great work! I'm looking forward to this getting merged :)

Should this be a requirement in the `test.requirements.txt` instead? Running `python -m pip install -r requirements.txt` installs all the packages in all the XXX.requirements.txt files, so I don't think it...