Timothy Meehan

Results 89 comments of Timothy Meehan

Can you modify title and description to more clearly articulate the problem being solved?

It appears this is failing: ``` Require upper bound dependencies error for org.checkerframework:checker-qual:3.37.0 paths to dependency are: +-com.facebook.presto:presto-postgresql:0.287-SNAPSHOT +-com.google.guava:guava:26.0-jre +-org.checkerframework:checker-qual:3.37.0 (managed)

Is this a cherry pick? At first glance, I don't see substantial similarities with the referenced PR.

Based on my reading of the code, this wouldn't qualify as a cherry pick as it's substantially different, and even the way it's performed is different between the two systems....

@mbasmanova it would be nice to fix the image as well--can you help @kevinwilfong with how you generated it?

> > Instead of making changes directly to `Type`, can we just have a new utility method in the Iceberg connector which takes in the Type, the Object, and from...

Perhaps we can use Omnigraffle, which stores the graphic as code? Here's an example for T-Digest: https://github.com/prestodb/presto/tree/b463cd0b9ae9e499515fe186bc3f1271b2644d5c/presto-main/src/main/java/com/facebook/presto/tdigest/docs

Omnigraffle is not an open tool. We can begin to use a new tool to generate these diagrams which is in an open format. But I feel it's not acceptable...

@evanvdia is this ready for review? There is a merge conflict.

@evanvdia are you working on this?