Tim Ledbetter

Results 56 issues of Tim Ledbetter

This PR replaces calls to `release_value_but_fixme_should_propagate_errors()` with `TRY()` where it is trivial to do so.

👀 pr-needs-review

These options allow the user to pause and manually refresh updates. This is similar to a feature present in older versions of the Windows Task Manager. I made the refresh...

stale

Previously, using the `--tmpdir` option with a template containing a path didn't work correctly, as the template path would be discarded. Examples of the `--tmpdir`/`-p` option being used after this...

👀 pr-needs-review

This PR ensures that errors are propagated from the HexEditor find dialog. I also included a commit to change the `OptionId` enum to match our current code style.

👀 pr-needs-review

When mousing over the right-hand side of the demo window on [this MDN site](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select), I get a crash with the following stack-trace: ``` VERIFICATION FAILED: m_ptr at /home/tim/repos/serenity/Meta/Lagom/../../AK/RefPtr.h:280 /home/tim/repos/serenity/Build/lagom/lib/liblagom-ak.so.0(ak_verification_failed+0xef) [0x7f5634fa019f]...

bug
regression

![ladybird_aur_after](https://github.com/SerenityOS/serenity/assets/2817754/c4efe1d5-768a-4f70-8b04-3f3b93d1421a) I believe this is being caused by a floating element within a `` Simplified reduction from the [Ladybird AUR page](https://aur.archlinux.org/packages/ladybird): ```html div { float: left; } Incorrectly positioned ```

bug
web compatibility
has-repro
reduction-of-web-content

Previously, we were attempting to add an empty string to the most recently open files list when no file was saved. `Application::set_most_recently_open_file()` now asserts that the path you are trying...

👀 pr-needs-review

Setting this attribute to "on" makes the entire document editable. Demo: https://github.com/SerenityOS/serenity/assets/2817754/43a11cd5-9730-4527-b40d-68fe4fa88332 Note: Trying to edit more complex websites doesn't work too well at the moment. Simpler websites like serenityos.org...

👀 pr-needs-review

Reproduction steps: 1. Open Browser in Serenity 2. Press Ctrl + U to View Source (or any other shortcut) 3. Nothing happens I've bisected the issue to 27d40bafc9d8c035710390dec4a7bbbb8801a51b. CC: @trflynn89

bug
regression
has-repro

I've included a dictionary of constants taken from [the PAM format specification](https://netpbm.sourceforge.net/doc/pam.html) to improve coverage. NB: The above link doesn't mention the CMYK TUPLTYPE. I included it in the dictionary...

✅ pr-community-approved