Thomas Citharel

Results 447 comments of Thomas Citharel

My mistake, I just noticed https://github.com/nextcloud/server/pull/32361 didn't take into account this case properly. The personal calendar will indeed still be used if it exists even if deleted. Now what should...

> they can't do anything about it The difference between « no slots available » and « an error has occurred » is that they can report it to whoever...

Basic public calendar write API has been added in nextcloud/server#29188

Do you have both `phpsessionclean.service` and `phpsessionclean.timer` activated?

> I saw some code instances where federated sharing was accessing the system address book. Should this behavior be influenced by the backend option I have added? Trusted servers exchange...

Nope, everything seems to be exposed. The only way to filter them may be to use [the `CLOUD` property](https://github.com/nextcloud/server/blob/1a255379e85f02f3fb301f709720f3210f56b011/apps/dav/lib/CardDAV/Converter.php#L97-L101).

> Extract the event comparisons into its own service What if we extracted the event comparison part in something that's usable for other things like for improved activity entries? For...

> Checkout S3 [...] implementation as Carl raise some concerns Yeah, since automatic expiration of versions is handled by the S3 platform itself, `oc_files_versions` will reference non-existing versions. Maybe there's...

I used an app config instead of a system config value as this can be sensitive (could be a bad idea to use a path mounted on external storage for...