ICS export doesn't contain DESCRIPTION for VALARM

[hackbaellchen]

Steps to reproduce

1. Create an event in a calendar using the browser and add a reminder (if not added automatically)
2. Export calendar to .ics (in my case by sharing an export link)

Expected behavior

The VALARM-field should have an editable or default (Google calendar uses "This is an event reminder") DESCRIPTION-field.

Actual behaviour

Generated event reminders VALARM are missing the DESCRIPTION-field, which is mandatory according to RFC5545.

Calendar app version

3.5.0

CalDAV-clients used

No response

Browser

Firefox 104.0.2

Client operating system

Windows 10 21H2

Server operating system

Debian 11

Web server

No response

Database engine version

No response

PHP engine version

No response

Nextcloud version

24.0.4, docker image nextcloud:24.0.4-apache

Updated from an older installed version or fresh install

Updated from an older version

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

I am using the python library ics to parse the exported calendar from nextcloud. When loading, ValueError: A VALARM must have at least one DESCRIPTION is thrown.

[rscmbbng]

Can reproduce with ics-py 0.7.1 and Calendar 3.4.2

[tcitworld]

It should just be about adding the description property in these two places: https://github.com/nextcloud/calendar-js/blob/c15736727eae56844b3c966ed4ae6a7f49eab042/src/components/root/abstractRecurringComponent.js#L769-L772 https://github.com/nextcloud/calendar-js/blob/c15736727eae56844b3c966ed4ae6a7f49eab042/src/components/root/abstractRecurringComponent.js#L786-L790

Apparently when the action is AUDIO the DESCRIPTION isn't required, so we need handling here (even though we don't support that in Calendar itself - yet?).

Also I wonder if we correctly add SUMMARY when action is EMAIL as well. :thinking:

[miaulalala]

It should just be about adding the description property in these two places: https://github.com/nextcloud/calendar-js/blob/c15736727eae56844b3c966ed4ae6a7f49eab042/src/components/root/abstractRecurringComponent.js#L769-L772 https://github.com/nextcloud/calendar-js/blob/c15736727eae56844b3c966ed4ae6a7f49eab042/src/components/root/abstractRecurringComponent.js#L786-L790

Apparently when the action is AUDIO the DESCRIPTION isn't required, so we need handling here (even though we don't support that in Calendar itself - yet?).

Also I wonder if we correctly add SUMMARY when action is EMAIL as well. 🤔

Bless you for this Thomas, I was looking for the export function 😅

[JulienPalard]

Can reproduce with calendar 3.5.2 (on framagenda.org instance).

[tcitworld]

Will be fixed by #4683

[st3iny]

Fixed by https://github.com/nextcloud/calendar/pull/4683.