Ondřej Kupka comments

Results 44 comments of


                                            Ondřej Kupka

put function should copy Prefix

I am not sure we need to copy the prefix by default, perhaps it would be better to leave it like that and just document that the tree is taking...

put function should copy Prefix

@emrekzd Alright, I will think about it...

Fuzzy/substring search

@ozeidan What about some benchmarks as mentioned by @vassudanagunta ? That would be really handy to get some insight into how faster things are...

Should keep track of size in a variable

Noted, I will take a look when I have some spare time.

Should keep track of size in a variable

To be honest, I am not sure whether to implement this or not. It would depend on the use cases. This would require keeping subtree item count in every trie...

Any way to check if all messages sent before calling client.Close()?

I find it pretty weird that in the code it says that it is draining messages on `quit` closed, then it does `flush`, `sendAsync`, `send` and there is interrupts on...

Any way to check if all messages sent before calling client.Close()?

So am I missing something or you can just end up with no messages actually sent when you `Enqueue` and immediately `Close`?

Any way to check if all messages sent before calling client.Close()?

Oh, I see, the `quit` channel is consulted only on retry.

@inconshreveable From what I understand after reading https://golang.org/doc/install/source, the variable has a default value, which is `$HOME/go1.4`. So making sure the variable is set is perhaps not 100% correct. But...

Easier Bootstrap for Go 1.5+

IMO it is enough to have Go `>= 1.4`. This is the error message from `make.bash`: ``` Set $GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4. ``` So in...