Tommy Byrd

Results 33 comments of Tommy Byrd
trafficstars

@SGrondin This is not directly related to this issue, but we're having a similar memory issues with [Probot](https://github.com/probot/probot/) apps after >2.9.0. I looked at the `limiter.on('debug')` messages and can see...

> Have you positively pinpointed v2.9.0 as the beginning of the issue? We're not ๐Ÿ’ฏon exactly 2.9.0, but we run the Slack integration on Probot and it's showing [v2.8.0](https://github.com/integrations/slack/blob/master/package-lock.json#L951), and...

> Would you be able to help test them? I can definitely help test them. The only reliable way I've been able to reproduce the problem is putting load on...

@SGrondin Thanks! I'm unleashing the chaos moneky on them now! I'll have some data for your tomorrow.

So far it looks like both branches are getting GCd as expected: **2.13.0**: ![image](https://user-images.githubusercontent.com/13207348/49260443-98318580-f40b-11e8-8fca-8b408c240338.png) **scope-fix-1**: ![image](https://user-images.githubusercontent.com/13207348/49260465-b4352700-f40b-11e8-94a5-5f416bf1f241.png) **scope-fix-2**: ![image](https://user-images.githubusercontent.com/13207348/49260495-cadb7e00-f40b-11e8-89a2-2074f9a81012.png) I'm not reading too much into the different shapes of the branches....

This all sounds great @SGrondin. At least as far as the projects I'm working on can be considered, this bit... > the user will have the option to provide a...

> Then it hit me that obviously, github isn't really serving from the ghpages branch, but that there's some deployment happening behind the scenes which could require a different auth)....

Just wanted to circle back here and let you know we recently moved the underlying Pages app to use GitHub App tokens, so the change in this PR to use...

@JamesIves I was testing this last night in one of my repos and had it working with the `x-access-token` method. We had an incident this morning that would have caused...

Interesting. I can see it's still getting the same error, as if it's not using the app token yet even though it clearly should be. Let me double check a...