Thomas Capelle comments

Results 169 comments of


                                            Thomas Capelle

feat(weave): Adds Dataset.map and progress bars

@andrewtruong as I added a method to dataset, is it normal that the hashes changes? (and thus the failing tests)

feat(weave): Adds Dataset.map and progress bars

> Yes. Since you added a new `op`, the digest is expected to change How do I fix the tests then?

feat(weave): Add progress bar to Evaluation.evalute.

If I randomly print text on the model it doesn't disturb the progress:

feat(weave): Add progress bar to Evaluation.evalute.

Is this still necessary @andrewtruong ?

feat(weave): Add progress bar to Evaluation.evalute.

![Screenshot 2025-03-17 at 16 52 39](https://github.com/user-attachments/assets/796a204a-f341-4ceb-8166-b4575e17aff6) we do get weird behavior here

feat(weave): Add progress bar to Evaluation.evalute.

I still prefer this weird behavior than what we have now.

feat(weave): HF.Datasets <-> weave.Dataset

Can we merge this @andrewtruong ?

Add design patterns / architecture overview to docs

You could add a section about the flow: # GRPO Repeated Sampling Flow Implementation This document explains how this GRPO implementation generates multiple different completions for each prompt when `num_generations...

Outlines doesn't install on Collab because Rust isn't available to compile outlines core

same on a fresh Linux VM