proposal-source-phase-imports icon indicating copy to clipboard operation
proposal-source-phase-imports copied to clipboard

Published 20 hours ago • verified publisher icon tc39

Stage 3 reviews

Open lucacasonato opened this issue 2 years ago • 8 comments

Issue to track Stage 3 reviewers feedback

Spec: https://tc39.es/proposal-import-reflection/

Review PR: https://github.com/tc39/ecma262/pull/3094

Reviewers:

  • [x] @nicolo-ribaudo
  • [x] @littledan
  • [x] @kriskowal

Editors:

  • [x] @bakkot
  • [x] @syg
  • [x] @michaelficarra

lucacasonato avatar Nov 24 '22 19:11 lucacasonato

The notes only indicate two reviewers; was nicolo confirmed in plenary?

ljharb avatar Nov 24 '22 21:11 ljharb

I don't remember if I volunteered in plenary or after, but we can confirm it after the status update at the upcoming meeting if necessary.

nicolo-ribaudo avatar Nov 25 '22 15:11 nicolo-ribaudo

All my feedback about observable semantics and spec correctness has been addressed in https://github.com/tc39/proposal-import-reflection/pull/36 (+ my follow-up https://github.com/tc39/proposal-import-reflection/pull/37).

I opened https://github.com/tc39/proposal-import-reflection/pull/38 to discuss reverting the changes that this proposal does to the 262-HTML layering, but I don't think that that is a stage 3 blocker so consider my Stage 3 review done ✔️

nicolo-ribaudo avatar May 10 '23 09:05 nicolo-ribaudo

My Stage 3 review is complete ✔️ I’m happy with the semantics.

kriskowal avatar May 15 '23 18:05 kriskowal

LGTM, I'm happy with the semantics and specification text, though I'd prefer that #38 land (since it constrains hosts to be more regular).

littledan avatar May 15 '23 18:05 littledan

The proposal has now been raised as an ECMA262 PR for easier reviewing: https://github.com/tc39/ecma262/pull/3094

lucacasonato avatar Jun 08 '23 18:06 lucacasonato

Where is the HTML integration PR for the new host hook and the change to HostLoadImportedModule?

syg avatar May 13 '24 23:05 syg

@syg I'm in the process of rebasing the HTML PR to the latest spec changes. but the host hook doesn't actually integrate into the HTML PR - it's entirely defined in the Wasm ESM integration in https://webassembly.github.io/esm-integration/js-api/index.html#hostgetmodulesourcename.

guybedford avatar May 14 '24 00:05 guybedford