Tommy.Tesla comments

Results 9 comments of


                                            Tommy.Tesla

OnChange event not firing when using ck-editor in source mode

Why do not just add a change event... Above solutions are so tedious.

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

What's wrong with the CI? The change should have nothing to do with the error. :)

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

@rgoers Agree! This PR is intended to do that as you proposed. Hope this could be supported ASAP :) . Have a nice day.

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

@rgoers Do you mean all the pre-loaded Lookups should be loaded via ServiceLoader? I am glad to contribute to this part if you do not mind. :)

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

@rgoers ok.

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

@jvz @rgoers It seems the Log4jPlugins class is moved from org.apache.logging.log4j.core.plugins. However in Activator class, Log4jPlugins is still imported as "org.apache.logging.log4j.core.plugins.Log4jPlugins".

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

@rgoers @jvz Hi, are you busy? Could you get round to take a review and merge :).

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

@rgoers I propably misunderstood your opinion: **_In essence, StrLookup would become the service interface and every plugin to be pre-loaded would be listed in the services file instead of hard...

Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

@rgoers Hi, rgoers. After debuging and reading the log4j2 codes, I realize that the **_public Interpolator(final Map properties)_** is called several times during factory creation stage. Is that reasonable to...