vocabulary icon indicating copy to clipboard operation
vocabulary copied to clipboard

Published 20 hours ago • verified publisher icon tasdikrahman

timeouts

Open blissend opened this issue 7 years ago • 2 comments

How are they dealt with?

Looking at https://github.com/tasdikrahman/vocabulary/blob/9d8870c7ba3678b88850ea1c82ff5b9cbacce47a/vocabulary/vocabulary.py#L89 for example doesn't show any setting for it. Would it be possible to add one considering http://docs.python-requests.org/en/master/user/quickstart/#timeouts states it could hang indefinitely?

blissend avatar Dec 16 '17 01:12 blissend

How are they dealt with?

As of now, they are not being dealt with. But it's definitely a good to have feature for more robustness.

Would it be possible to add one considering

I would love for contributions from others :)

tasdikrahman avatar Dec 17 '17 20:12 tasdikrahman

I would love for contributions from others :)

I thought about it but I prefer using a class configurable variable (self) which would go against the design in place (staticmethods). :(

blissend avatar Dec 24 '17 17:12 blissend