Tariq Soliman

Results 11 comments of Tariq Soliman

Hi @andresinho20049 and thanks for the PR! A couple of things: - Please PR into the `development` branch. `master` is solely for the latest release. - (I agree there should...

Thanks! As a workaround in the meantime, a custom marker icon can be configured too. Search "markerIcon" in https://nasa-ammos.github.io/MMGIS/configure/layers/vector

1. There's nowhere in the code that defaults a name to "Earth". 2. In the /upsert body, `config.msv.mission` is required and generally should remain the same as the top level...

Thanks, I'll improve the documentation here. And `"Layer x has URL "` looks right to me. but I'll include quotes around its value so it's more clear. (`"Layer x has...

Could you provide an example curl command that fails this way. I retested it locally and it does work without a `version` specified. And going off of the `"Failed to...

Yep. In the first image, because you passed "version", it took that version's configuration object and updated (made a next version of) the configuration. v2 and v67 of that mission's...

Yeah, but `version` takes precedence. Like: ```javascript if(body.version != null) { body.config = getMissionConfig(body.mission, body.version) } upsertConfig(body.config) ```

I suppose it could. Would it be better to state in the docs that `mission` is required and then either `version` or `config` is required but not both?

There's still some misunderstanding so hopefully this helps. - /api/configure/upsert will never create new missions -- it will only ever update existing mission configurations - You never update a specific...

As an alternative to Selenium and while I have not used it myself (yet), I know of other teams who have and who have praised https://github.com/microsoft/playwright (primarily JS but there's...