Dario Seminara
Dario Seminara
Ok! I will work on that. I will start by writing tests for GamepadController class (mocking gamepad API) . We need tests for react components that were modified too ?
I can't see tests on current version of jsnes-web So, I will follow this guide [https://facebook.github.io/create-react-app/docs/running-tests](https://facebook.github.io/create-react-app/docs/running-tests) to start adding the tests. It is ok ? (sorry, I am newbie on...
Great, I will follow the actual scheme then
I am sorry to hear that, maybe I should fix that in a separated pull-request. What platforms we should cover ? IE? edge too?
Just tested [jsnes.org](jsnes.org) on edge and IE11 and the gamepad seems to be broken at all. Also tested on [https://html5gamepad.com/](https://html5gamepad.com/) and again the gamepad doesn't seems to work at all....
Anyway. I will fix the case where both getGamepads and webkitGetGamepads are not present. I think I have to code more defensively, sorry
Here it is [https://github.com/bfirsh/jsnes-web/pull/167](https://github.com/bfirsh/jsnes-web/pull/167)
Fixed on 137927b
Fixed on v0.0.14
Sorry, this is not implemented yet, methods with splat arguments hasn't special signature