Tarik Eshaq

Results 42 comments of Tarik Eshaq

> but what I don't quite understand is how this is actually a "dry run"? It'll be the app that runs this as a "dry run", the app will construct...

> I don't think this code changes very often and there's no pressing need to merge this. What if we held it here in a PR for a while and...

Hmmm Looks like reason this is a crash is https://github.com/mozilla-mobile/android-components/blob/62fe384048d6c4048c0ddd60befa1158774b3589/components/browser/storage-sync/src/main/java/mozilla/components/browser/storage/sync/PlacesHistoryStorage.kt#L159 doesn't do the "handlePlacesExceptions" dance to catch exceptions Although it's a low frequency, it's a crasher so I'll put up...

The exception handling for the crash landed in https://github.com/mozilla-mobile/android-components/pull/12112 I'll keep this ticket open since we didn't find the root cause the error is thrown, but I'll change the title...

Won't land till I get local builds of iOS and Android to verify this works, this should be good for review though

Lets not merge this until I can clear out why FxA thinks some devices aren't syncing, when they definitely are

Thank you! Looks like they have an issue for that: https://github.com/chronotope/chrono/issues/499, adding it here for future reference.

Looks like this is still common in release, ref: https://sentry.prod.mozaws.net/operations/firefox/issues/9612438/?query=is%3Aunresolved%20Database Should #4639 be prioritized? The count is high

Looks unrelated, but might be? I opened a PR for an issue I had with building our android code: #4846

I'mma hop on this since I saw the invitation on Element 😛 I haven't been following too closely how the tool has grown over the past few months, but.. There...