Louis Eisenberg

Results 57 comments of Louis Eisenberg

I agree that making non-backward-compatible changes shouldn't be a huge deal at this stage, especially if the tabulator shows a helpful error message instead of just crashing. But also, for...

Note that this also needs to work for the sequential case. I'm fixing that output logic in #291.

Are we still comfortable that this is non-essential? I'm working on #189 and would need this issue to be addressed in order to automate testing of my work.

(Note that we also labeled #189 as non-essential, so we're being consistent.)

I don't have a strong opinion here. I agree that our current practice of generating a separate file per precinct is unwieldy. I think a single file would be the...

Yeah, I already have those same settings, and they don't quite match DefaultPrettyPrinter. Have you actually tried creating and committing a new JSON file? We can make the colon spacing...

Yes, we do have a number of duplicate CVR files in the test data. If we wanted to avoid that, we would need to create an exception to the naming...