rcv icon indicating copy to clipboard operation
rcv copied to clipboard

Support precinct summary file comparison for regression testing

Open moldover opened this issue 7 years ago • 5 comments

Regression tests need to compare actual tabulation result file to expected result files. Our tabulator "discovers" precinct IDs during the course of tabulation. We would need some way of exposing these IDs to the test harness, and mapping them to a list of known files.

moldover avatar Dec 17 '18 06:12 moldover

Do we need this for certification? It would seem likely to me.

freedomcounts avatar Jun 10 '19 19:06 freedomcounts

Note that this also needs to work for the sequential case. I'm fixing that output logic in #291.

tarheel avatar Jun 22 '19 07:06 tarheel

I think this is the same issue I ran into today: precinct tests like precinct_example and missing_precinct_example currently only compare the overall .json summary to a single expected file. They should compare each precinct summary as well (including the missing one in the latter case).

HEdingfield avatar Jul 03 '19 05:07 HEdingfield

Are we still comfortable that this is non-essential? I'm working on #189 and would need this issue to be addressed in order to automate testing of my work.

tarheel avatar Jul 07 '19 06:07 tarheel

(Note that we also labeled #189 as non-essential, so we're being consistent.)

tarheel avatar Jul 07 '19 06:07 tarheel