Michaël Zasso
Michaël Zasso
@codebytere sorry for the spam. I wrote here as I was experiencing it, didn't want to forget anything 😄 . There are some things to fix, but I like it!
I'm giving it a try now with 12.17.0
> Has the embedder string been incremented? In addition of the verification, `git node land` could even automatically increment the embedder version if needed.
@joyeecheung > @targos The easiest way to get this done is to operate on a per-PR basis i.e. do not mix V8 update commits in normal PRs otherwise it's hard...
Still an issue: https://github.com/nodejs/node-core-utils/runs/2797236866
I would avoid to change the format of the PR-URL line. It might break other tools like the changelog generator.
Maybe still 50 commits? V8 updates often come close to 25.
It's actually a documentation issue. That is already possible with ``` $ ncu-ci run 12345 ```
Example: PR: https://github.com/nodejs/node/pull/30123 Landed on master in https://github.com/nodejs/node/commit/511f67bcb42b59c9a3a3efab8fed578db100afe1 Landed on v13.x in https://github.com/nodejs/node/commit/d549a34597d8d9f8489de748e42eefdd148d0bef Landed on v12.x in https://github.com/nodejs/node/commit/375f349760d141b37abe5e7119aab243426eb2f4 Did not land on v10.x or v8.x
Seems like it could be useful. Do you already have an idea about how we would store and process these data?