Michaël Zasso

Is it supposed to ask me for my GitHub credentials? It blocks immediately at: ``` $ /home/mzasso/git/nodejs/node-core-utils/bin/git-node release --promote 32813 ⠋ Verifying Releaser statusIf this is your first time running...

Okay, I found that I can enter my username/password/otp code and it continues. Then: ``` ⠴ Verifying Releaser status ✔ Received member information of nodejs/releasers ✔ undefined is not a...

The output of the next steps is weird: ``` ✔ Done loading data for nodejs/node/pull/32813 ... skipped some lines ✔ Approvals: 6 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/32813#pullrequestreview-393019854 ✔...

Then it crashes on the secure tag step: ``` ? Tag and sign the release? Yes Error: /home/mzasso/git/nodejs/node-core-utils/node_modules/git-secure-tag/lib/git-secure-tag/batch.js:83 throw new Error(`Unexpected reply for ${object}`); ^ Error: Unexpected reply for at...

@codebytere yeah, I actually did not have my `.ncurc` (it doesn't work well with the `npm-check-updates` lib and I have to move the file when I use it). I put...

I wonder why it said that the PR does not have sufficient approvals. It has 6 of them 🤔

This is what is passed to `runSync` for the secure tag: ``` /home/mzasso/git/nodejs/node-core-utils/node_modules/.bin/git-secure-tag [ 'v13.13.0', '813052119e9b73411534e2c50b027781e8882e10\n', '-sm', `"'2020-04-14, Node.js v13.13.0 (Current) Release"` ] ```

The branch switching doesn't work: ``` ? Merge proposal branch into staging branch? Yes ⠋ Merging proposal branchError: Switched to branch 'v13.x' at exports.runSync (/home/mzasso/git/nodejs/node-core-utils/lib/run.js:60:11) at ReleasePromotion.mergeProposalBranch (/home/mzasso/git/nodejs/node-core-utils/lib/promote_release.js:292:5) at ReleasePromotion.promote...

^ That's because `runSync` throws `child.stderr` as an error if it's not empty. But git sometimes outputs its messages to stderr. What should we do here?

The promotion step doesn't work. It stops immediately with a success message, but the promotion did not happen (note that the promotion script is interactive so we may have to...