Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

Create new github-bot personal token for nodejs/tweet automation

Create PAT for blocklist import/export

incident: iojs+release is spinning up new jobs in a loop

can't we enforce a value for certain fields in jenkins?

1bit greyscale encoder support

Hello, would you be able to share a problematic image with us? There is nothing that specifically forbids 1bit images (https://github.com/image-js/fast-png/blob/master/src/PngDecoder.ts#L475-L486), but it is not tested because we have never...

1bit greyscale encoder support

I see. Feel free to try and implement it here if you want!

Convert indexed data into RGB data

Thanks for the PR! Can you please remove the second commit? Our repositories expect npm7+ to be present (peer dependencies are installed automatically with it).

Convert indexed data into RGB data

I'll have a closer look at the code in a few days, as the implementation is quite different than the one I did in `image-js`: https://github.com/image-js/image-js/blob/5811f5b7e7677cdda1d8ac124a5c963812e5cd59/src/image/core/load.js#L99-L124

Convert indexed data into RGB data

> > Can you please remove the second commit? > > Done > > But in my case, it breaks `lint` tests > > https://github.com/microshine/fast-png/runs/4118047939?check_suite_focus=true The Prettier errors can be...

Normalize to RGBA when decoding indexed images

* A `normalize` options sounds good. Do you think it should be a general option (that would normalize any image to 32-bit RGBA) or just something that handles palette conversion?...

undici.fetch does not append url fragments (url.hash)

I thought that the fragment should not be sent to the remote server?