admin icon indicating copy to clipboard operation
admin copied to clipboard

Create PAT for blocklist import/export

Open bnb opened this issue 2 years ago • 12 comments

For https://github.com/nodejs/.github/pull/1 to be able to actually be run, it will need a PAT from an account that is an admin of both organizations - meaning, nodejs/ and pkgjs/. My assumption is that if @nodejs-github-bot isn't already an admin of pkgjs/, we should trivially be able to fix that but it'll still need to be done.

As such, I'm explicitly requesting a PAT with the admin:org scope be created for the nodejs/.github so the import/export tooling can be run. The admin:org scope is required by GitHub, and documentation for this requirement can be found here.

bnb avatar Mar 24 '22 16:03 bnb

cc @nodejs/tsc

bnb avatar Mar 24 '22 16:03 bnb

added label since this has been open for two weeks with no review and I need +1s from the @nodejs/tsc 😅

bnb avatar Apr 07 '22 07:04 bnb

+1

targos avatar Apr 07 '22 07:04 targos

+1

mhdawson avatar Apr 07 '22 19:04 mhdawson

+1

BridgeAR avatar Apr 13 '22 21:04 BridgeAR

I just tried to help @bnb by trying to create the token, but I don't have the authentication credentials for @nodejs-github-bot. Can someone else step in to do this? @nodejs/tsc @nodejs/github-bot @nodejs/build

Trott avatar Apr 18 '22 15:04 Trott

Sure, I can create a token for the github-bot. Its credentials are part of the secrets repo too for future ref.

Do we have preferred ways of sharing such a token?

phillipj avatar Apr 18 '22 19:04 phillipj

@phillipj if you'd want to just add it to the nodejs/.github repo as a GitHub Secret so you don't need to share it, that'd be sick. Ideally, it'd be named BLOCKLIST_TOKEN since that's what the current PR (https://github.com/nodejs/.github/pull/1) uses, but I can change if needed :)

bnb avatar Apr 18 '22 20:04 bnb

@bnb sounds good to me 👍🏻 I've already created the token, so if you provide me sufficient privileges in that repo, I'll create BLOCKLIST_TOKEN ASAP

phillipj avatar Apr 18 '22 21:04 phillipj

AFAIK I only have the ability to provide that access via being an owner from the Moderators team, which I am not supposed to use for that. @Trott / @nodejs/tsc if one of y'all could maybe add @phillipj with the admin role to that repo and remove him when he done adding the token? 🙇🏻

bnb avatar Apr 18 '22 21:04 bnb

I've added @phillipj as Admin on nodejs/.github. Let me know when you no longer need it.

aduh95 avatar Apr 18 '22 22:04 aduh95

BLOCKLIST_TOKEN repository secret added.

@aduh95 feel free to remove my admin privileges.

phillipj avatar Apr 19 '22 07:04 phillipj