Michaël Zasso
Michaël Zasso
It broke everything. I found another way to make it right: https://github.com/nodejs/node-v8/commit/bf2905726eab2409da70af57a6f787823f0a2f06
CI: https://ci.nodejs.org/job/node-test-commit/70322/
Build is fixed. I'll close tomorrow if the canary release works
Finally :sob:
Can you show an example use case?
Note that the current way memory grows is by doubling the buffer size. Many software do it like this.
Debug build fails on my mac: ``` FAILED: gen/node_snapshot.cc cd ../../; export BUILT_FRAMEWORKS_DIR=/Users/mzasso/git/nodejs/v8-next-update/out/Debug; export BUILT_PRODUCTS_DIR=/Users/mzasso/git/nodejs/v8-next-update/out/Debug; export CONFIGURATION=Debug; export EXECUTABLE_NAME=node; export EXECUTABLE_PATH=node; export FULL_PRODUCT_NAME=node; export PRODUCT_NAME=node; export PRODUCT_TYPE=com.apple.product-type.tool; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk; export...
@anonrig any idea why macOS fails to build on GitHub actions (simdutf-related error)? I didn't get this error locally.
@miladfarca thanks for the heads up. I believe both commits are included already.
I see, thanks @Renegade334. I think the easiest for now is to revert https://chromium-review.googlesource.com/c/v8/v8/+/6449193, since it touches a feature that's in development and behind a flag.