Michaël Zasso
Michaël Zasso
Restarted the work in https://github.com/image-js/tiff/tree/jpeg
> In any case, we can always use the CI for that. That's probably the best thing to do. I guess we can apply the patch temporarily if needed, but...
@StefanStojanovic V8 update PR: https://github.com/nodejs/node/pull/51362
Yes, they're still broken, and the fix from https://github.com/nodejs/node/pull/51362/commits/6f6a7fc5d02c76ac85a12e43ad6ce126d35283ca doesn't apply cleanly to V8's lkgr branch.
I'll check tomorrow
Still fails, but now for a different reason: https://ci-release.nodejs.org/job/iojs+release/10154/nodes=vs2022-x64/console ``` 12:35:17 Creating library out\Release\node_mksnapshot.lib and object out\Release\node_mksnapshot.exp 12:35:21 Creating library out\Release\cctest.lib and object out\Release\cctest.exp 12:35:23 node_mksnapshot.vcxproj -> out\Release\\node_mksnapshot.exe 12:35:23 node_mksnapshot...
@joyeecheung does that ring a bell?
It's https://github.com/v8/v8/commit/f4e06442848677b3f9fae50495f7fe0f3d8f0c20 Needs a gyp variant of https://github.com/v8/node/pull/176
I pushed https://github.com/nodejs/node-v8/commit/47d38753d1d5ffd1e481e931088f626f862ae8c2 🤞🏻
Added https://github.com/nodejs/node-v8/commit/d9ccae42aff6ff0bca41850edea9f7f4e245656e and https://github.com/nodejs/node-v8/commit/052e970b190f5341841f3d690affe149fab16b75 to fix another issue.