Tony Arcieri

Results 2560 comments of Tony Arcieri

@ashWhiteHat can you open a new PR with just the `rc6` implementation?

The main argument for re-encryption is having a consistent behavior across all of our crates, IMO. Currently all of them except for `ascon-aead` will return a buffer containing the ciphertext.

Nearly all of the current implementations are currently two-pass and return the unaltered ciphertext buffer on tag verification failure. No mutation of the buffer is performed at all in that...

A chosen ciphertext attack requires a decryption oracle. If a user submits any message as the "ciphertext", what they get out of re-encryption is the original message they submitted, not...

> This implementation has one issue - it panics on non-utf-8 file names which is a legitimate scenario Perhaps use `PathBuf` instead of `String`?

Sure, sounds great! Re: OIDs for RFC5753, that should be pretty easy to add: https://github.com/RustCrypto/formats/tree/master/const-oid/oiddbgen Please open a separate issue and/or PR for that

You can add a git dependency, that's fine

I'm not personally using it so I don't have a strong opinion. It seems useful for `blake2`, though I notice the `blake3` crate doesn't use it.

Hmm, so it turns out `argon2` was using this: https://github.com/RustCrypto/password-hashes/blob/master/argon2/src/blake2b_long.rs