Tony Arcieri
Tony Arcieri
AEAD decryption-in-place traits with additional tag processing, created for committing AEAD wrappers
Aha, that makes sense. Thanks.
@baloo is there a specific reason this is still draft? It'd be good to get it landed so we make sure it gets updated when `ed448-goldilocks` is changed
See also: https://github.com/RustCrypto/KEMs/issues/53
That certainly is an obnoxious key format, I guess due to backwards compatibility with implementations who started using those encodings without first discussing how they should work. Well, we should...
I don't think we should support serialization of the expanded format at all. IMO it was a mistake that it was ever included, which occurred because certain implementers of the...
Traits like `EncodePrivateKey` aren't designed to support multiple serializations, and IMO it was a mistake to even include the expanded key whatsoever. Most implementations aren't supporting it at all.
Note that I’m slightly less opposed to being able to *decode* the other formats. I just don’t want to encourage their proliferation by serializing/encoding such schemes
Also [`std::num::NonZero`](https://doc.rust-lang.org/std/num/struct.NonZero.html) provides a generic solution
The reason this hasn't been merged yet is because it hasn't yet been code reviewed, which is especially important for cryptographic code. Please give us time to review it. If...
The test failures look unrelated. We'd still be interested in this if you could rebase!