Tony Arcieri

Results 2560 comments of Tony Arcieri

If you'd like to use both the `p256` and `k256` crates, you can use generics rather than macros. We can potentially add some upstream hints/marker traits to these crates to...

@DanGould the main advantages of `k256` are it’s pure Rust and shares a common trait-based API with `p256`, whereas `secp256k1` is an FFI wrapper for a C library.

It should just require running `cargo audit` to update Cargo.lock. Perhaps we should set up dependabot.

Just a note that this approach looks good, however the PR is marked as draft and failing CI

While I agree with everything you're saying, note that the error messages, API, and inability to handle the misconfiguration are all artifacts of the `librpm` API itself and don't have...

That's unfortunate. This library has been written to use a relatively simple and conservative API strategy [based on discussions with RPM developers](https://github.com/rpm-software-management/rpm/issues/429#issuecomment-400461227) about how to, given their massive amount of...

`TransactionSet` has a (legacy) `Drop` impl: https://github.com/RustRPM/librpm.rs/blob/13ce47/src/internal/ts.rs However it's stored in a `lazy_static`: https://github.com/RustRPM/librpm.rs/blob/13ce47/src/internal/global_state.rs#L14 and since it has a `'static` lifetime, it's never dropped. One option might be to use...

It'd probably be good to get the docs building on https://docs.rs if we can: https://docs.rs/crate/librpm/0.1.1/builds/122833 It seems we might be able to request librpm be added as a dependency. Here's...

It's a bit hard to read the error since it looks misaligned, but it appears to be saying that `delMacro` is undefined. That function would be defined by `bindgen`, and...

Do you see `delMacro` on your local copy of the docs? https://rustrpm.org/librpm_sys/fn.delMacro.html