Tony Arcieri comments

Results 2560 comments of


                                            Tony Arcieri

Native channels on JRuby don't work with JDK builtin selectors

Failing everything else, I think these sort of hierarchical selector setups can be written on top of nio4r, as opposed to requiring first-class support. First-class support would be nice though....

Inconsistent end of stream handling in ByteBuffer::read_from

I guess the question here is: what should the behavior be? Throw `EOFError`? Return `nil`?

Consider ditching domain_name?

Awesome, great news!

Replace `quarter_round` in xchacha with soft backend version

It seems it was duplicated because `soft` isn't always available: https://github.com/RustCrypto/stream-ciphers/actions/runs/8427139184/job/23077019314?pr=349#step:7:106 ``` Compiling chacha20 v0.10.0-pre (/project/chacha20) error[E0432]: unresolved import `crate::backends::soft` --> chacha20/src/xchacha.rs:11:22 | 11 | use crate::backends::soft::quarter_round; | ^^^^ could...

Replace `quarter_round` in xchacha with soft backend version

Now I'm noticing we should really get #333 landed first

Replace `quarter_round` in xchacha with soft backend version

@oxarbitrage need to re-evaluate this PR now that #333 has been merged

Replace `quarter_round` in xchacha with soft backend version

Thanks!

Making `panic-never` a requirement or convention for `rust-embedded` libraries where feasible

Something of a sidebar, but: is anyone aware of a tracking issue for adding a first-class feature for this to `rustc`? I know there are a few options for this...

Making `panic-never` a requirement or convention for `rust-embedded` libraries where feasible

> If RTIC handled panics How? Most Rust embedded projects I've seen implement very simple panic handlers that do something like specify an `eh_personality` lang item that goes into an...

Making `panic-never` a requirement or convention for `rust-embedded` libraries where feasible

> Or you can use fallible accessors The [`get`](https://doc.rust-lang.org/std/primitive.slice.html#method.get) and [`get_mut`](https://doc.rust-lang.org/std/primitive.slice.html#method.get_mut) methods of the slice primitive are fantastic for this, especially since thanks to the [`SliceIndex`](https://doc.rust-lang.org/std/slice/trait.SliceIndex.html) trait they can be...