JP Sugarbroad

I know it's a weird combo (no halting debug is rare), but if we read this from IPSR instead of ICSR we avoid the problem altogether. https://github.com/rust-embedded/cortex-m/blob/1a215916eeebdf96d4530e0afb1baa91b93eefb7/cortex-m-rt/macros/src/lib.rs#L227

Export ptp layer

6

Some devices support additional functionality, but without access to the ptp_* functions it is not possible to use them without modifying the library. Could we export `ptp.h` and the related...

Switch to CDN for live assets

2

I see a number of links to `https://raw.githubusercontent.com/stimm4711/gloomhaven/master` in the beta branch, and I recommend switching to a CDN: https://www.jsdelivr.com/?docs=gh Also you may wish to link to a tag instead...

Use storage access framework to avoid needing storage permissions

4

https://developer.android.com/guide/topics/providers/document-provider You want the `ACTION_CREATE_DOCUMENT` version. I think it also lets people directly store backups on Google Drive or Dropbox.

Variable redeclared in inner scope

3

Input: -> v = '' -> loop await f defer v Expected result: "var v" only appears at top of function. Actual result: "var v" appears at top of function...

Don't build loop results if they're not used

8

In while loops, it would be nice we could skip construction of the _results array (and the associated _next function) if the loop results aren't used. This code isn't optimized...

Input: -> (autocb) -> Expected output: (function() { return function(autocb) { autocb(); }; }); Actual output: (function() { autocb(function(autocb) { autocb(); return; }); return; });

Leaving this here for the eventual polish phase of the spec: There are two places where `max-age` is called as "positive integer", which excludes the zero value. In section 6...

[FR] Support os.PathLike objects

4

I prefer to use pathlib.Path objects, but helpers like `distutils.Command.make_file` only accept strings: https://github.com/pypa/distutils/blob/27638e388d8ae92368e5459254b59a026e73b1cd/distutils/cmd.py#L387-L391 Filing this issue before I go in and make a PR to change these to `os.PathLike`...

Seems to be no way to call SetDefaultExtension, which impairs UX somewhat. :(