Tanner Gooding

Results 379 comments of Tanner Gooding

The docs are correct. We might be able to add a statement differentiating between compile time constant vs supported range. Maybe something like: > While the full range of `nint`...

CC. @stephentoub, @michaelgsharp for libraries side CC. @dotnet/jit-contrib for the JIT side CC. @fanyang-mono for the Mono side Most of this change is in managed code with the Mono and...

@fanyang-mono, for when you do review there's some iOS/tvOS failures that look unique to this PR but where it isn't clear what could be causing it as they seem to...

> Tests? Ah, I thought I pushed them up, I might have them in a different branch. Will get those up here shortly.

-- Think I almost have the mono stuff working, it's not easy testing all the scenarios (JIT, LLVM, Interp) locally (especially for iOS/tvos), so relying a bit on CI here

Resolved merge conflicts. This should be ready for review on both the Mono (CC. @steveisok, @fanyang-mono) and RyuJIT (CC. @dotnet/jit-contrib) side.

SPMI replay failure is https://github.com/dotnet/runtime/issues/104585

Triaging: `TimeProvider` belongs to `System.DateTime`, not `System.Runtime`.

The test here should likely be filtered out on WASM for the time being, with a tracking issue against it. WASM isn't technically doing anything wrong here, normalizing `NaN` is...