Tanner Gooding

Results 379 comments of Tanner Gooding

> I've chosen this benchmark for a reason, it's very poor. There is a certain level of responsibility on the code author to write good code when they want performance....

I can take a look and see if I can find an initial root cause, but I expect this is likely a JIT issue and unrelated to the libraries side...

I'm not able to reproduce the failure locally, on a machine with or without AVX512. My best guess is that in some edge case scenario the code is calling the...

The issue is fixed with https://github.com/dotnet/runtime/pull/102098 and so disabling shouldn't be needed, just final sign-off If, for whatever reason, the test still shows as flaky somewhere after then I think...

CC. @jkotas this should be ready now. Only spmi is left and they are rerunning due to failing to download the mch file

CC. @dotnet/jit-contrib for secondary review. This puts CI into a clean state again

The remaining Arm64 failure is different from the issue that https://github.com/dotnet/runtime/issues/101731 is tracking (and not unique to this PR). I'm looking into it, but it would probably be good to...

Ping @dotnet/jit-contrib for review, this resolves the main CI issue. https://github.com/dotnet/runtime/pull/102162 fixes the remaining pre-existing issue, but is libraries side only

This was resolved in https://github.com/dotnet/runtime/pull/102874

The support should already exist, but it's not been validated as I have no way to test mobile devices in CI. For v2.1.2 (the latest mimalloc) their OS abstraction layer...