Tan Ho

Results 124 comments of Tan Ho

Oh! The dependencies were injected in the past but no longer injected there and now injected via f7Page https://github.com/RinteRface/shinyMobile/commit/63135abb0edce89a4b3b4cf9975214e2efe48a47 d'oh.

Appreciated this thread a bunch! I too nearly ran into a CRAN rejection for "global environment" but was able to demonstrate (with the help of this thread and Gabor's previous...

> Bummer, I've just run into this as well :/ @tyluRp this is fightable - I did end up winning on this! See the screenshot I had, where librarying the...

I'm hoping to use details block `in` shiny, not necessarily raw html in a details block :P e.g. avoiding this ![image](https://user-images.githubusercontent.com/38083823/114431426-7b85ea80-9b8d-11eb-9f71-e5e4ac696984.png) and getting this instead ![image](https://user-images.githubusercontent.com/38083823/114431605-ae2fe300-9b8d-11eb-8d0e-544c7acd88b2.png) (Problem is solved on...

> Error in loadNamespace(x) : there is no package called ‘nflverse’ This means you need to install nflverse - https://github.com/nflverse/nflverse > `nflverse_sitrep()` can be found in nflreadr

plurals worth fixing for sure, as is column order. > I think weekly = FALSE df should still have `season` variable. weekly=FALSE is meant to create one row for the...

> The game winning field goal stats are calculated differently. I could not find your filter logic for the current implementation but that should be an easy fix. Thinking out-loud:...

> I did not increment version number in Description file but will leave it up to you all if/how you want to incorporate it Please feel free to bump a...

Logic and code otherwise looks good! Please also add a NEWS.md bullet and bump a DESCRIPTION version number when you get a chance :)