Tan Ho

more globally, every NSE variable will need .data$ prefixed to it for CRAN purposes, e.g. every time you use a column name without quotations

Spent a stream working through this. TODO: - [x] fumbles review/refactor -> DONE, Seb, 2022/08/10 - [x] penalties review/refactor (I notice at the top it filters only to run/pass etc...

> @mrcaseb I can't review the output before it's released, right? Just tried now but looks like this pull request needs to be completed first. use `remotes::install_github("christianlohr9/nflfastR@formidable")`

uhh. try `remotes::install_github("christianlohr9/nflfastR-1@formidable")` christian named it something weird.

cannot repo the summarise inform messages locally, what is your `nflverse_sitrep()` now?

Separate function would be better. The calculate function code is long enough as it is, and users should primarily use nflreadr load anyway

> My biggest question about this function is at the highest level: does this function compute only defensive stats _while the player is on defense_, or does it compute the...

> I’m in agreement here. Actually, the more I think about it, the more it makes sense to me to keep a singular `calculate_player_stats()` function and just add a `side`...

I'm unavailable, but @christianlohr9 is the branch owner and should be able to add it to the branch directly!

I’m curious whether that is better or whether we should develop a true parallel to player stats (ie build up from pbp)