tan-t

Results 11 comments of tan-t

may it be the root cause? - this SDK defines SagemakerRuntime.invokeEndpointAsync operation as using `RestJson` protocol. https://github.com/aws/aws-sdk-js/blob/master/apis/runtime.sagemaker-2017-05-13.normal.json#L7 - this SDK calls JsonBuilder.build() when building request body, with `req.params` as argument....

yes this fails ``` (function () { const helpers = require('./helpers'); const { AWS, spyOn } = helpers; return describe('SagemakerRuntime.invokeEndpointAsync', function () { it('should call api with an empty body',...

I editted the SDK and the issue has been no longer reproduced. the PR is #4204 . I tried this: # (in `node` REPL on master branch) ``` const AWS...

@ajredniwja thank you for the reply! I'm glad to hear that you have reproduced the issue. I'm looking forward getting my PR reviewed, if any changes needed please let me...

wow so fast. thanks for reviewing. I'll fix them asap

@waffle87 @drashna thanks for the review! and sorry for the late response, I just have followed your feedbacks and made sure that CI Build successfully built. can you review it...

@fauxpark thanks for the review! I resolved all the suggestions. what should I do for the merge?

I would like to proceed to register my keyboard to other services which requires the keyboard to be merged to qmk_firmware (like VIA). If possible can you merge this soon?...