Tamir Duberstein comments

Results 362 comments of


                                            Tamir Duberstein

aya+ebpf: Implement read+write methods for PerfEventArray

Sorry, a dependency on what? I think you should make whatever you need public so that your test is representative of real usage.

aya+ebpf: Implement read+write methods for PerfEventArray

do the integration tests run for you on `main`? how are you running them? what versions of rustc and bpf-linker are you using?

aya: refactor handling of /proc/$pid/maps

> > @addisoncrump Can you check the API here and let me know if this is what you had in mind? > > Looks good. If you've got some time,...

aya: Return error messages from netlink

The second commit should probably go first? or they should be squashed?

PerfEvent error: Argument list too long (os error 7)

Can you write a test?

Features are incorrectly detected, resulting in load errors on some older kernels

Thanks for the detailed write-up! Would you be willing to contribute a fix? We've recently improved support for testing on multiple kernel versions, so if you write a test you'll...

Fix kernel version parsing failed too early.

This is the same as #909. Like that one, this needs tests.

integration-ebpf: artifact dependency bpf-linker

Drat. This breaks the workflows on stable because cargo refuses to read `test/integration-ebpf/Cargo.toml` which now contains `artifact = ...` even though we `--ignore integration-ebpf` on the command line. I'm thinking...

Relocation Integration Tests Fail on Kernel 6.2

Is this still a thing? I believe we run under 6.1 in CI. https://github.com/aya-rs/aya/blob/461c2759c58f31af7a2ea396a477f8a8c0f8875f/.github/workflows/ci.yml#L224

false positives in protobuf generated code

I don't feel that strongly about this - we're easily ignoring those files with a simple grep. Perhaps a flag that ignored files based on regex would be useful, but...