Raul Tambre

Results 76 comments of Raul Tambre

curl doesn't seem to use any extended POSIX functions that'd require this. Don't know which others you're referring to so I can't comment on those. But to explain better: libssh2...

> only LibreSSL sets it, when `CMAKE_SYSTEM_NAME MATCHES "Linux"` I could probably scope similarly here. I just don't have any non-Linux systems to verify if it's necessary there too (LibreSSL's...

> FTR only Linux had references to _DEFAULT_SOURCE in system headers. Changed the checks to `CMAKE_SYSTEM_NAME MATCHES "Linux"`. > Can you say what errors do you see? I tried with...

> I wonder if it'd be a better approach to update the code to not use POSIX extensions? > In case of popen(), perhaps defining _DEFAULT_SOURCE in-source would be better,...

I'll open a separate PR to try bump maximum CMake range and add to a `CMAKE_C_EXTENSIONS=OFF` combination to CI.

@vszakats Minor ping. Let me know if I should bring the CI commit into this PR. 🙂