Yotam Mann comments

Results 85 comments of


                                            Yotam Mann

Use reciprocal of tempo when syncing time signals to Transport

Great PR! thanks you!

Setting Player.playbackRate makes the Tone Transport out of sync

Thanks for the issue! probably related to [this commit](https://github.com/Tonejs/Tone.js/commit/d788183425fe4a23bca4dccddd939c3384b10045). When i have a minute, i'll try to figure out how to roll this commit back without re-introducing the issue i...

Ability to pass credentials and other fetch parameters when fetching audio buffers

thanks @zya i'm into this feature! a PR would be great and should be relatively simple. You're imagining that the second argument would be passed in entirely to `fetch`? Looks...

Ability to pass credentials and other fetch parameters when fetching audio buffers

🙏🏻

mel scale for pitch linearRampToValue

I'm open to this option. Seems pretty cool. @kmjasmin if we include Mel, do we need to include Bark or any other perceptually-based scales? curious to know if there's any...

[Feature] Callback when finishing a sequence / pattern

It seems like this should be possible to do outside of Tone.js without setting a timeout or computing the duration of the sequence. Sequence/Pattern are already giving you a callback....

Strange Tone.Bitcrush error on Firefox

thanks @thely, very strange error. My guess is that it comes from the BitCrusher's AudioWorklet script which is loaded using a Blob Url. I'm not sure why it's appearing in...

Strange Tone.Bitcrush error on Firefox

@chrisguttandin interesting, thanks for the tip

Examples on homepage not working on Safari 14.1

This seems to be because that little examples UI uses BroadcastChannel to communicate between the worker thread and the main page. ![image](https://user-images.githubusercontent.com/1323402/126905774-c8d26b79-8378-4541-a425-986db805a145.png) I should update that little widget to use...

Cycling envelopes

Thanks for this suggestions @munozu Since Web Audio envelopes are all scheduled, an onended callback of an envelope might come a little too late. By that i mean that if...