Yotam Mann comments

Results 84 comments of


                                            Yotam Mann

Implement Player with Reverb Effect

Does the codesandbox that i posted work for you?

revisited: DC Filter UPDATE!!!

@Hazmatron7 looks like you've done a lot of great work on this! would you like to submit a PR with this class? I can provide a deeper review to the...

revisited: DC Filter UPDATE!!!

@Hazmatron7 thank you, this looks very good and thorough! The first step is to hit the "fork" button to create your own version of the repo. You can then add...

Feature Request: audio rate sample-and-hold

Thanks for the reference implementation. I think a Sample-And-Hold component would be really cool. The big issue blocking your implementation for the time being is that it still doesn't seem...

Part re-start behavior issues

thanks for jumping in @Seanitzel, but this does seem like a situation that we'd like to support. Though there are ways around this specific issue as you mentioned. I looked...

Player chain Destination in offline context

thanks for jumping in @Valent-in

Way to obtain control limitations for each control on each module

Take a look at the [data.json](https://unpkg.com/browse/[email protected]/docs/) which is distributed as part of the npm package. A lot of that information is already in there. You'll see in the code for...

actually close audio context when disposing it

Thank you @marcelblum for this PR and for all your help in the repo in general! very much appreciated.

Scheduling bufferSources in 14.7.x an offline scheduleRepeat causes strange glitching.

The issue is that the function `handleToneTransportTick` is being played in the "online" context even when you're rendering with Tone.Offline. The glitch that you're hearing is all the notes playing...

ToneEvent callback triggering twice

Could you try it on `tone@next`? I wonder if this might have already been fixed by some recent updates