Tamas Kenez comments

Results 6 comments of


                                            Tamas Kenez

find_package(OpenColorIO) broken under cmake 3.29.1

I've just found the same issue with building Qt on GitHub. It's failing there with cmake 3.29.1 while 3.29.2 on my machine works fine. The problem seems to be in...

find_package(OpenColorIO) broken under cmake 3.29.1

Github runners have been updated now.

Make pxrTargets.cmake relocatable (when built with TBB and OpenSubdiv)

> Looks good! Personally I like the `if(NOT DEFINED` checks, but their absence isn't enough to hold this up. Yes, I agree, rebased and fixed in https://github.com/PixarAnimationStudios/OpenUSD/commit/e59b22f35adcb037b6ab57764c838817add01271

[bug] CMAKE_OSX_DEPLOYMENT_TARGET may be overridden by CMake projects which set it as cache variable before the first project command

**[EDIT: this comment is now obsolete, it's referring to the original title "CMakeToolchain does not set CMAKE_OSX_DEPLOYMENT_TARGET as a cache variable"]** The Conan CMake toolchain file does set `CMAKE_OSX_DEPLOYMENT_TARGET` as...

[bug] CMAKE_OSX_DEPLOYMENT_TARGET may be overridden by CMake projects which set it as cache variable before the first project command

Thank you, @jwillikers , I added a note to my comment, it's obsolete now.

[bug] CMAKE_OSX_DEPLOYMENT_TARGET may be overridden by CMake projects which set it as cache variable before the first project command

Also, about my earlier suggestion: > On the contrary, if conan_toolchain.cmake set it as a normal variable, then it would override the existing cache variable. But I don't know if...