sleap icon indicating copy to clipboard operation
sleap copied to clipboard

Allow retracking of old predictions

Open getzze opened this issue 3 years ago • 3 comments

Software versions: SLEAP: 1.2.8

Description

PR #898 allows to retrack predictions, but for using with the GUI, it would be nice to have the option to define a prediction file to retrack. This PR adds options to the GUI for that. It also makes retrack work with the GUI, it's currently broken.

It could be done better if the option was added in the predict_on combo_list at the bottom of the inference window, but it was a bit too complicated to understand how this widget is populated... This is work in progress.

Types of changes

  • [x] Bugfix
  • [x] New feature
  • [ ] Refactor / Code style update (no logical changes)
  • [ ] Build / CI changes
  • [ ] Documentation Update
  • [ ] Other (explain)

getzze avatar Sep 30 '22 18:09 getzze

Codecov Report

Merging #975 (24f58b2) into develop (4d1154e) will decrease coverage by 0.74%. The diff coverage is 53.12%.

:exclamation: Current head 24f58b2 differs from pull request most recent head c12129e. Consider uploading reports for the commit c12129e to get more accurate results

@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
- Coverage    67.55%   66.80%   -0.75%     
===========================================
  Files          130      127       -3     
  Lines        22248    21515     -733     
===========================================
- Hits         15030    14374     -656     
+ Misses        7218     7141      -77     
Impacted Files Coverage Δ
sleap/gui/learning/runners.py 32.50% <41.66%> (+0.40%) :arrow_up:
sleap/nn/tracking.py 74.57% <41.93%> (+2.17%) :arrow_up:
sleap/nn/inference.py 78.87% <76.19%> (-0.13%) :arrow_down:
sleap/io/dataset.py 83.26% <0.00%> (-0.24%) :arrow_down:
sleap/gui/commands.py 58.32% <0.00%> (-0.09%) :arrow_down:
sleap/instance.py
sleap/message.py
sleap/__init__.py
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 30 '22 18:09 codecov[bot]

Hi @getzze,

I see your description says this PR is a "work in progress". Just checking-in to see if it is ready for review?

Thanks, Liezl

roomrys avatar Nov 08 '22 01:11 roomrys

Hi @roomrys, So, it's working but I'm not very satisfied with it, but I don't know how to improve it. So it would be nice if I can get some feedback from you :) Thanks!

getzze avatar Nov 15 '22 23:11 getzze