(3g -> 3f) Use frame group for triangulation

[roomrys]

Description

This PR makes use of the FrameGroup and InstanceGroup classes and uses them for triangulation.

Types of changes

• [ ] Bugfix
• [x] New feature
• [ ] Refactor / Code style update (no logical changes)
• [ ] Build / CI changes
• [ ] Documentation Update
• [ ] Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

• [ ] Review the guidelines for contributing to this repository
• [ ] Read and sign the CLA and add yourself to the authors list
• [ ] Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
• [ ] Add tests that prove your fix is effective or that your feature works
• [ ] Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

:heart:

[coderabbitai[bot]]

Walkthrough

The modifications in the sleap project focus on enhancing the FrameGroup class to better support instance triangulation, alongside a significant reduction in the associated unit tests. This suggests a streamlined approach in handling triangulation, possibly indicating a shift in how instances are verified and triangulated within the application.

Changes

File Path	Summary
sleap/gui/commands.py	Updated FrameGroup class to better filter and handle instance groups for triangulation.
tests/gui/test_commands.py	Removed multiple test functions related to triangulation, reducing testing coverage.

🐰🌟 To the code that leaps and bounds, Through digital fields, where logic sounds. Triangulate with care and might, In SLEAP's realm, enhance the sight. Oh, how the frames now smartly group, With fewer tests, the project's troop! 🎉🐾

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 628d7db24a92f02a97461dee1a62384e8be9d8fc and efbafda8fbdafd94d974e65ae28f5c6f30cdb541.

Files selected for processing (2)

• sleap/gui/commands.py (2 hunks)
• tests/gui/test_commands.py (1 hunks)

Additional comments not posted (1)

sleap/gui/commands.py (1)

3409-3465: Ensure that the triangulation process correctly filters and handles instance groups based on the new criteria.

The changes in the triangulateSession method involve updating the handling of FrameGroup and InstanceGroup to ensure that only instance groups with a sufficient number of instances are considered for triangulation. This aligns with the PR's objective to enhance the triangulation process by utilizing these classes more effectively.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.